Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11520 )
Change subject: socket.c: fix IP and port buffer sizes ...................................................................... Patch Set 1: Code-Review+1 in both cases this reduces the buffer size, resp. from 16 to 6 and from 64 to 46. It's probably correct and not harmful, but I ask myself, why bother? -- To view, visit https://gerrit.osmocom.org/11520 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia25e2f3277ad2f60df31c08d12f42c1e6d2a14a6 Gerrit-Change-Number: 11520 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Comment-Date: Tue, 06 Nov 2018 19:22:22 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes
