Max has posted comments on this change. ( https://gerrit.osmocom.org/11686 )
Change subject: ipaccess-config: Add -G cmdl opt to query OML IP and Unit ID ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/11686/2/src/ipaccess/ipaccess-config.c File src/ipaccess/ipaccess-config.c: https://gerrit.osmocom.org/#/c/11686/2/src/ipaccess/ipaccess-config.c@616 PS2, Line 616: fprintf(stderr, "getting Attributes (%d): %s\n", nmsg_get->len, osmo_hexdump(msgb_data(nmsg_get), msgb_length(nmsg_get))); why stderr here? https://gerrit.osmocom.org/#/c/11686/2/src/ipaccess/ipaccess-config.c@622 PS2, Line 622: printf("abis_nm_ipaccess_set_nvattr\n"); and stdout here? -- To view, visit https://gerrit.osmocom.org/11686 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ida416a969a3309868d6f4e50f34b34f224c32dd6 Gerrit-Change-Number: 11686 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Max <[email protected]> Gerrit-Comment-Date: Thu, 08 Nov 2018 14:35:50 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
