Max has posted comments on this change. ( https://gerrit.osmocom.org/11680 )
Change subject: abis_nm: Allow sending and receiving Get Attributes (Response) against nanoBTS ...................................................................... Patch Set 1: (1 comment) Could you split moving code to separate function and adding support for another BTS type into different patches? You are doing several things at the same time in nearby code and it's difficult to track all changes here. https://gerrit.osmocom.org/#/c/11680/1/src/osmo-bsc/abis_nm.c File src/osmo-bsc/abis_nm.c: https://gerrit.osmocom.org/#/c/11680/1/src/osmo-bsc/abis_nm.c@531 PS1, Line 531: static int parse_attr_resp_info(struct gsm_bts *bts, const struct gsm_bts_trx *trx, struct abis_om_fom_hdr *foh, struct tlv_parsed *tp) Can you make *bts const? -- To view, visit https://gerrit.osmocom.org/11680 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I53d01e73791cf5450aa34b1ac8f051730e3a70f9 Gerrit-Change-Number: 11680 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Max <[email protected]> Gerrit-Comment-Date: Thu, 08 Nov 2018 14:48:44 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
