Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11683 )
Change subject: abis_nm: parse_attr_resp_info_unreported: Fix offset calculation ...................................................................... Patch Set 1: > That's odd - is there some test case which could catch that? Also, > describe in commit message what exactly is fixed, what was broken > before, how it was tested etc. No test case, but that +2 doesn't make sense after looking at surrounding code and specs. Have a look at: 3GPP TS 52.021 §8.11.3 Get Attribute Response 3GPP TS 52.021 §9.4.64 Get Attribute Response Info -- To view, visit https://gerrit.osmocom.org/11683 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie61d70bc28427d5d879638516a36f590ce98bdc7 Gerrit-Change-Number: 11683 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-CC: Max <[email protected]> Gerrit-Comment-Date: Thu, 08 Nov 2018 14:54:44 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
