Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11692 )
Change subject: abis_nm: Split handling of Attribute Response Info into its own func ...................................................................... Patch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/11692/1/src/osmo-bsc/abis_nm.c File src/osmo-bsc/abis_nm.c: https://gerrit.osmocom.org/#/c/11692/1/src/osmo-bsc/abis_nm.c@581 PS1, Line 581: parse_attr_resp_info(bts, trx, foh, &tp); evaluate return val, to preserve the 'return -EINVAL' we had before. Heck, you could just 'return parse_attr_resp_info(...)' https://gerrit.osmocom.org/#/c/11692/1/src/osmo-bsc/abis_nm.c@582 PS1, Line 582: (whitespace) -- To view, visit https://gerrit.osmocom.org/11692 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I346dacc58faac70e6d224ca49484f9211cb8a046 Gerrit-Change-Number: 11692 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Comment-Date: Thu, 08 Nov 2018 16:51:22 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
