Pau Espin Pedrol has submitted this change and it was merged. (
https://gerrit.osmocom.org/11610 )
Change subject: layer23: Avoid mempcy with NULL src
......................................................................
layer23: Avoid mempcy with NULL src
Fixes following ASan warning:
git/osmocom-bb/src/host/layer23/src/misc/../common/main.c:146:2: runtime error:
null pointer passed as argument 2, which is declared to never be null
The warning however is harmless since in that case, app_len = 0 and thus
size to copy is 0.
Change-Id: I009a5b53f1e5be72ce347d64d3a7cb1d95d37ea3
---
M src/host/layer23/src/common/main.c
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
Neels Hofmeyr: Looks good to me, approved
diff --git a/src/host/layer23/src/common/main.c
b/src/host/layer23/src/common/main.c
index 693b10e..2920cd9 100644
--- a/src/host/layer23/src/common/main.c
+++ b/src/host/layer23/src/common/main.c
@@ -143,7 +143,8 @@
*option = talloc_zero_array(l23_ctx, struct option, len + app_len + 1);
memcpy(*option, long_options, sizeof(long_options));
- memcpy(*option + len, app_opp, app_len * sizeof(struct option));
+ if (app_opp)
+ memcpy(*option + len, app_opp, app_len * sizeof(struct option));
}
static void handle_options(int argc, char **argv)
--
To view, visit https://gerrit.osmocom.org/11610
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I009a5b53f1e5be72ce347d64d3a7cb1d95d37ea3
Gerrit-Change-Number: 11610
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Pau Espin Pedrol <[email protected]>
Gerrit-Reviewer: Vadim Yanitskiy <[email protected]>
Gerrit-Reviewer: daniel <[email protected]>
