Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11684 )
Change subject: abis_nm: Introduce new signal S_NM_GET_ATTR_REP ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/11684/3//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/11684/3//COMMIT_MSG@11 PS3, Line 11: this signal in later patches. > Why do you really need a Change-id of a later patch? just look 1-2 patches > later, that's it. because when future readers go through the log, they want to know what is going on. Actually, if it is in the same repos, why not squash those two commits to begin with? Then the user of the signal is right there. -- To view, visit https://gerrit.osmocom.org/11684 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a121bbfe1b96904d4e16845abc90bb6ef20d2c9 Gerrit-Change-Number: 11684 Gerrit-PatchSet: 3 Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Comment-Date: Fri, 09 Nov 2018 13:48:16 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
