Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11695 )
Change subject: abis_nm: Support parsing nanoBTS format for Get Attributes Info ...................................................................... Patch Set 2: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/11695/1/src/osmo-bsc/abis_nm.c File src/osmo-bsc/abis_nm.c: https://gerrit.osmocom.org/#/c/11695/1/src/osmo-bsc/abis_nm.c@554 PS1, Line 554: if (rc > 0) { > I don't understand "the unreported part". Maybe it's just me. […] irc: <pespin> neels, maybe other BTS also do it, and it doesn't hurt doing the costless check, so I think it's fine the way it is now -- To view, visit https://gerrit.osmocom.org/11695 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I81a613d53bddf432a79fa5cb0bf9d847b4bdee37 Gerrit-Change-Number: 11695 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Comment-Date: Fri, 09 Nov 2018 13:53:13 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
