Stefan Sperling has posted comments on this change. ( 
https://gerrit.osmocom.org/11705 )

Change subject: detect freed connections in osmo_stream_srv_read()
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/11705/1/src/stream.c
File src/stream.c:

https://gerrit.osmocom.org/#/c/11705/1/src/stream.c@855
PS1, Line 855:  if (rc != -EBADF && (what & BSC_FD_WRITE))
> In all places I know of, we use -EBADF as an indicator that the osmo_fd 
> struct was freed and should  […]
Indeed, using EBADF is more consistent with other code. Thanks for hint.



--
To view, visit https://gerrit.osmocom.org/11705
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a9c7d8e3263c73440f7084dbb1792a4ca5038f0
Gerrit-Change-Number: 11705
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <[email protected]>
Gerrit-Reviewer: Stefan Sperling <[email protected]>
Gerrit-Comment-Date: Fri, 09 Nov 2018 14:44:43 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Reply via email to