Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11716 )
Change subject: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg. ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/11716/1/src/mncc.c File src/mncc.c: https://gerrit.osmocom.org/#/c/11716/1/src/mncc.c@400 PS1, Line 400: if (mncc->called.plan != GSM340_PLAN_UNKNOWN && mncc->called.plan != GSM340_PLAN_ISDN) { > It could also be a > greater than (1==GSM340_PLAN_ISDN) test. […] switch case seems a good option for me. switch(mncc->called.plan) { case GSM340_PLAN_UNKNOWN: case GSM340_PLAN_ISDN: return 1; default: LOGP() return 0; } -- To view, visit https://gerrit.osmocom.org/11716 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8d71cac5b169e3b19675b9b9626e6993f3acd979 Gerrit-Change-Number: 11716 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Whyte <ke...@rhizomatica.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Keith Whyte <ke...@rhizomatica.org> Gerrit-CC: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-CC: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Comment-Date: Mon, 12 Nov 2018 09:28:10 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
