Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11742 )
Change subject: coverity: gscon_forget_lchan: squelch forward-null ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/11742/1/src/osmo-bsc/bsc_subscr_conn_fsm.c File src/osmo-bsc/bsc_subscr_conn_fsm.c: https://gerrit.osmocom.org/#/c/11742/1/src/osmo-bsc/bsc_subscr_conn_fsm.c@655 PS1, Line 655: if (!conn || !conn->fi) Do we really then need this check at all if they are allocated and removed at the same time? "if (!conn)" should be enough right? -- To view, visit https://gerrit.osmocom.org/11742 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I62354aa998832131c86535f39a29294000114adc Gerrit-Change-Number: 11742 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Comment-Date: Mon, 12 Nov 2018 16:36:03 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
