osmith has posted comments on this change. ( https://gerrit.osmocom.org/11756 )
Change subject: gits: use @{u} to get upstream branch, not origin/%s
......................................................................
Patch Set 1:
(1 comment)
Nice! besides catching the git stderr this looks good to me.
https://gerrit.osmocom.org/#/c/11756/1/src/gits
File src/gits:
https://gerrit.osmocom.org/#/c/11756/1/src/gits@61
PS1, Line 61: return subprocess.check_output(['git', '-C', git_dir, ] +
list(args), stderr=subprocess.STDOUT).decode('utf-8')
why is this needed?
--
To view, visit https://gerrit.osmocom.org/11756
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife146903ae1323a4e568587ccfd4018725e9d719
Gerrit-Change-Number: 11756
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Comment-Date: Tue, 13 Nov 2018 10:31:59 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
