Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11656 )
Change subject: use enums consistently instead of falling back to int ...................................................................... Patch Set 2: (4 comments) https://gerrit.osmocom.org/#/c/11656/2/include/osmocom/sgsn/gprs_sndcp_comp.h File include/osmocom/sgsn/gprs_sndcp_comp.h: https://gerrit.osmocom.org/#/c/11656/2/include/osmocom/sgsn/gprs_sndcp_comp.h@47 PS2, Line 47: } algo; /* Algorithm type (see gprs_sndcp_xid.h) */ We have this kind of union twice, once in this file and in next file. I'm wondering whether it makes sense to define the union with a name, instead of creating same anonymous union twice. https://gerrit.osmocom.org/#/c/11656/2/include/osmocom/sgsn/gprs_sndcp_xid.h File include/osmocom/sgsn/gprs_sndcp_xid.h: https://gerrit.osmocom.org/#/c/11656/2/include/osmocom/sgsn/gprs_sndcp_xid.h@47 PS2, Line 47: What about defining it here? https://gerrit.osmocom.org/#/c/11656/2/include/osmocom/sgsn/gprs_sndcp_xid.h@61 PS2, Line 61: union { Here duplicate anonymous union. https://gerrit.osmocom.org/#/c/11656/2/src/gprs/gprs_sndcp_xid.c File src/gprs/gprs_sndcp_xid.c: https://gerrit.osmocom.org/#/c/11656/2/src/gprs/gprs_sndcp_xid.c@45 PS2, Line 45: union { And here it is, same anonymous union 3rd time. -- To view, visit https://gerrit.osmocom.org/11656 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3771a5c59f4e6fee24083b3c914965baf192cbd7 Gerrit-Change-Number: 11656 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Sperling <ssperl...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Stefan Sperling <ssperl...@sysmocom.de> Gerrit-CC: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 13 Nov 2018 11:03:14 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
