Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11764 )
Change subject: osmo-bts-trx: print TRX socket addresses in 'show transceiver' ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/11764/1/src/osmo-bts-trx/trx_vty.c File src/osmo-bts-trx/trx_vty.c: https://gerrit.osmocom.org/#/c/11764/1/src/osmo-bts-trx/trx_vty.c@70 PS1, Line 70: vty_out(vty, "TRX %d %s%s", trx->nr, osmo_sock_get_name(NULL, pinst->phy_link->u.osmotrx.trx_ofd_clk.fd), VTY_NEWLINE); you are leaking memory here, as the function you're calling allocates on the heap... -- To view, visit https://gerrit.osmocom.org/11764 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I081305d730cbdb14b5ce1dbfee18673328225b66 Gerrit-Change-Number: 11764 Gerrit-PatchSet: 1 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Comment-Date: Tue, 13 Nov 2018 15:58:27 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
