Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11765 )
Change subject: bts-trx: trx_if: Use struct to store CTRL msg parsed responses ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/11765/1/src/osmo-bts-trx/trx_if.c File src/osmo-bts-trx/trx_if.c: https://gerrit.osmocom.org/#/c/11765/1/src/osmo-bts-trx/trx_if.c@388 PS1, Line 388: sizeof I am afraid there is a risk of: https://www.geeksforgeeks.org/using-sizof-operator-with-array-paratmeters/ Not sure though, needs to be tested. -- To view, visit https://gerrit.osmocom.org/11765 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icb84bce0621042afa4301678ba1cc58d8e3662bb Gerrit-Change-Number: 11765 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Comment-Date: Tue, 13 Nov 2018 20:30:01 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
