Neels Hofmeyr has submitted this change and it was merged. (
https://gerrit.osmocom.org/11670 )
Change subject: lchan: set cause for 4 instances of release_in_error = true
......................................................................
lchan: set cause for 4 instances of release_in_error = true
Make sure some RSL cause is set.
Change-Id: I372ade9fc58919fbf858ce14caab8a0a22dbb083
---
M src/osmo-bsc/lchan_fsm.c
M src/osmo-bsc/lchan_rtp_fsm.c
2 files changed, 4 insertions(+), 0 deletions(-)
Approvals:
Pau Espin Pedrol: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c
index c3790e5..71b40c1 100644
--- a/src/osmo-bsc/lchan_fsm.c
+++ b/src/osmo-bsc/lchan_fsm.c
@@ -1056,6 +1056,7 @@
case LCHAN_EV_RSL_CHAN_ACTIV_ACK:
/* A late Chan Activ ACK? Release. */
lchan->release.in_error = true;
+ lchan->release.rsl_error_cause = RSL_ERR_INTERWORKING;
lchan_fsm_state_chg(LCHAN_ST_WAIT_RF_RELEASE_ACK);
return;
@@ -1067,6 +1068,7 @@
case LCHAN_EV_RSL_RF_CHAN_REL_ACK:
/* A late Release ACK? */
lchan->release.in_error = true;
+ lchan->release.rsl_error_cause = RSL_ERR_INTERWORKING;
lchan_fsm_state_chg(LCHAN_ST_WAIT_AFTER_ERROR);
/* TODO: we used to do this only for sysmobts:
int do_free = is_sysmobts_v2(ts->trx->bts);
@@ -1291,6 +1293,7 @@
default:
lchan->release.in_error = true;
+ lchan->release.rsl_error_cause = RSL_ERR_INTERWORKING;
lchan_fail("Timeout");
return 0;
}
diff --git a/src/osmo-bsc/lchan_rtp_fsm.c b/src/osmo-bsc/lchan_rtp_fsm.c
index e3e68e5..aaba563 100644
--- a/src/osmo-bsc/lchan_rtp_fsm.c
+++ b/src/osmo-bsc/lchan_rtp_fsm.c
@@ -725,6 +725,7 @@
{
struct gsm_lchan *lchan = lchan_rtp_fi_lchan(fi);
lchan->release.in_error = true;
+ lchan->release.rsl_error_cause = RSL_ERR_EQUIPMENT_FAIL;
lchan_rtp_fail("Timeout");
return 0;
}
--
To view, visit https://gerrit.osmocom.org/11670
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I372ade9fc58919fbf858ce14caab8a0a22dbb083
Gerrit-Change-Number: 11670
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Pau Espin Pedrol <[email protected]>
