Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11782 )
Change subject: unlink socket path correctly in rf_create_socket() ...................................................................... Patch Set 3: > Patch Set 2: > > > Patch Set 2: > > > > Can anyone tell what is up with the Jenkins builder? > > 'make check' is passing for me locally. > > OK I see there are additional tests which aren't enabled by default. > Will try to reproduce the problem locally. It is surprising, but it seems like this unlink() call has never worked right because tests are starting to fail with my initially proposed patch. So my next patch simply removes the unlink() call. -- To view, visit https://gerrit.osmocom.org/11782 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia0c873da305cbb47aef0562f61ec21057363f294 Gerrit-Change-Number: 11782 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Sperling <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-Comment-Date: Thu, 15 Nov 2018 17:48:36 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
