Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11792 )
Change subject: libmsc: Don't send SMS STATUS REPORT locally if the ESME accepted it. ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Looks fine, only one cosmetic issue though. https://gerrit.osmocom.org/#/c/11792/3/src/libmsc/gsm_04_11.c File src/libmsc/gsm_04_11.c: https://gerrit.osmocom.org/#/c/11792/3/src/libmsc/gsm_04_11.c@690 PS3, Line 690: Let's please avoid mixing tabs and spaces when it's not required. I recommend either use a tab here, or not to wrap the line at all. -- To view, visit https://gerrit.osmocom.org/11792 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3529b89535800eaa1127721d613fa7bbcb8b23be Gerrit-Change-Number: 11792 Gerrit-PatchSet: 3 Gerrit-Owner: Keith Whyte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Fri, 16 Nov 2018 14:12:06 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
