Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11571 )
Change subject: UHDDevice: setRxGain on chan 0 when using multi-arfcn ...................................................................... Patch Set 1: (1 comment) I don't think 'Same check is done in getRxGain' is a good explanation ;) What did inspire you to write this change? What was broken before? > we avoid outputing an error which error exactly? https://gerrit.osmocom.org/#/c/11571/1/Transceiver52M/device/uhd/UHDDevice.cpp File Transceiver52M/device/uhd/UHDDevice.cpp: https://gerrit.osmocom.org/#/c/11571/1/Transceiver52M/device/uhd/UHDDevice.cpp@489 PS1, Line 489: It would be great to have a comment here instead of the ws, describing why do we need to overwrite chan? It should be clarified. -- To view, visit https://gerrit.osmocom.org/11571 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b02bb1ef6450dc48be7b8058d96a5691847d3cc Gerrit-Change-Number: 11571 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Fri, 16 Nov 2018 15:50:12 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
