Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11679 )
Change subject: Move msgb_push helpers to public header ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/11679/1/include/osmocom/core/msgb.h File include/osmocom/core/msgb.h: https://gerrit.osmocom.org/#/c/11679/1/include/osmocom/core/msgb.h@378 PS1, Line 378: static inline unsigned char *msgb_push_TLV1(struct msgb *msgb, uint8_t tag, this is just a wrapper around msgb_tlv_push() with addressof-value and length 1. Please use a inline function or #define rather than re-implementing this from gsm/tlv.h -- To view, visit https://gerrit.osmocom.org/11679 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37e91d031fba28cf1c6735b8069b0265746f55e6 Gerrit-Change-Number: 11679 Gerrit-PatchSet: 1 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Comment-Date: Sun, 18 Nov 2018 20:19:04 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
