Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11791 )
Change subject: bsc: vty: Verify and warn on invalid arfcn passed ...................................................................... Patch Set 4: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/11791/4/src/osmo-bsc/bsc_vty.c File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/#/c/11791/4/src/osmo-bsc/bsc_vty.c@3125 PS4, Line 3125: vty_out(vty, "%% Invalid arfcn %" PRIu16 " detected%s", arfcn, VTY_NEWLINE); normally we just use %u for uint*_t. I choked on that practice very early on when starting on Osmocom, but have not seen a single problem with that. -- To view, visit https://gerrit.osmocom.org/11791 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib001501bf37289e824a1f72b62afde23892e88d2 Gerrit-Change-Number: 11791 Gerrit-PatchSet: 4 Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Tue, 20 Nov 2018 00:33:51 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
