Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11766 )
Change subject: bts-trx: setup timer once at creation time ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/11766/3//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/11766/3//COMMIT_MSG@15 PS3, Line 15: > I was first a bit confused, because the part of moving the alloc of the > parent struct to a separate […] Unfortunately, gerrit orders the list of files changed in a way that makes it difficult to understand the different parts, if you look at them in reverse order it's a lot easier to follow. I had to add new alloc/init functions to be able to set parameters in a way without coupling code and exposing stuff from different modules. -- To view, visit https://gerrit.osmocom.org/11766 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b6461d0130d25284e673c5efce0b3832c48bbb5 Gerrit-Change-Number: 11766 Gerrit-PatchSet: 3 Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-CC: Harald Welte <lafo...@gnumonks.org> Gerrit-Comment-Date: Tue, 20 Nov 2018 09:36:40 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
