osmith has posted comments on this change. ( https://gerrit.osmocom.org/11740 )
Change subject: publish from project repos, not this repo anymore ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/11740/2/contrib/jenkins.sh File contrib/jenkins.sh: https://gerrit.osmocom.org/#/c/11740/2/contrib/jenkins.sh@7 PS2, Line 7: echo "Manuals have been moved to the projects, and need to be published from there." > Mentiond that "make publish" exists now? I will added it to the INSTALL.txt and refer to that instead of the wiki page. https://gerrit.osmocom.org/#/c/11740/2/contrib/jenkins.sh@9 PS2, Line 9: echo "<https://osmocom.org/projects/cellular-infrastructure/wiki/Osmocom_Manuals>" > why the <...> braces though? I've seen this in license texts (e.g. GPL headers) and then doing it like that, but that's not a good reason. I'll omit this in the future. > Are you planning on adding info to that wiki page? so far it doesn't have > anything about publishing, except some half-hearted dependency list. That was the idea. > In fact, I think the place that explained how to publish so far was the > osmo-gsm-manuals/README .. or INSTALL.txt. Maybe link there instead, also > from the wiki page, and fully explain there? Right, I will extended the INSTALL.txt instead and refer to that file. Also the wiki page links to that file now instead of showing the incomplete dependency list. -- To view, visit https://gerrit.osmocom.org/11740 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe0424ceace151115985896b6d43035c69067c50 Gerrit-Change-Number: 11740 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Comment-Date: Tue, 20 Nov 2018 14:53:21 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
