Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11806 )
Change subject: cosmetic: update usage of OSMO_GSM_MANUALS_DIR ...................................................................... Patch Set 2: Code-Review+2 I would have assumed it would suffice to just point to the git clone, installing not needed, after all it's just some adoc, no linked libraries. But ok, if it works like this then let's apply this as it is, we can still bother about local-clone fallback another time. Rather be done with this before we merge more manuals patches. -- To view, visit https://gerrit.osmocom.org/11806 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64cfffb5104edcf7a20f41aeb5bf8ee6988b57c4 Gerrit-Change-Number: 11806 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Tue, 20 Nov 2018 16:03:57 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes
