Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11802 )
Change subject: Osmo*/Makefile.am: use $(srcdir) ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/11802/1/OsmoBSC/Makefile.am File OsmoBSC/Makefile.am: https://gerrit.osmocom.org/#/c/11802/1/OsmoBSC/Makefile.am@1 PS1, Line 1: OSMO_GSM_MANUALS_DIR = $(realpath $(srcdir)/..) > See my reply here: […] Oh, I see, you probably mean to use $(top_srcdir)! It looked like it was moving out of the tree, but in fact $(top_srcdir) would be better here. (fyi, there's also $(top_builddir)) -- To view, visit https://gerrit.osmocom.org/11802 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2454d7507fae4e1c47458a1adf36f68e637f4bbc Gerrit-Change-Number: 11802 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Comment-Date: Tue, 20 Nov 2018 16:08:14 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
