Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11856 )
Change subject: check ioctl() call return value in tun_new() ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/11856/1/lib/tun.c File lib/tun.c: https://gerrit.osmocom.org/#/c/11856/1/lib/tun.c@198 PS1, Line 198: SYS_ERR(DTUN, LOGL_NOTICE, errno, "could not disable checksum on %s", (*tun)->devname); > LOGL_ERROR? I intentionally decided not to use LOGL_ERROR because this failure is not treated as a fatal condition. Compare to how TUNSETIFF ioctl failure is handled. -- To view, visit https://gerrit.osmocom.org/11856 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88da2164d975d7a232619b8d31c5eadeef0f3a80 Gerrit-Change-Number: 11856 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Sperling <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-Comment-Date: Wed, 21 Nov 2018 14:24:19 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
