Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11820 )
Change subject: LCLS: update parameter representation ...................................................................... Patch Set 3: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/11820/3/src/osmo-bsc/osmo_bsc_lcls.c File src/osmo-bsc/osmo_bsc_lcls.c: https://gerrit.osmocom.org/#/c/11820/3/src/osmo-bsc/osmo_bsc_lcls.c@163 PS3, Line 163: static struct osmo_lcls old_cfg_csc = { 0 }; I still have the filling this variable being static (aka global) is most probably wrong, since I guess we need to keep this status per-conn/subscriber or per-call. Please have a look at it and submit a patch regarding this issue. -- To view, visit https://gerrit.osmocom.org/11820 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5e962d4fbb24bf1fb2398dc13e142a4a3304d858 Gerrit-Change-Number: 11820 Gerrit-PatchSet: 3 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Thu, 22 Nov 2018 10:44:43 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
