Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11871 )
Change subject: properly store IPv6 addresses in struct tun_t ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/11871/1/lib/tun.c File lib/tun.c: https://gerrit.osmocom.org/#/c/11871/1/lib/tun.c@279 PS1, Line 279: netdev_delroute(&tun->dstaddr.v4, &tun->addr.v4, &tun->netmask); Just wondering, is this only needed for IPV4? What about IPv6? I see we also have a dstaddr in tun_setaddr6. https://gerrit.osmocom.org/#/c/11871/1/lib/tun.c@332 PS1, Line 332: strncpy(snet, inet_ntoa(tun->addr.v4), sizeof(snet)); Isn't this reading out of bounds? (also before this change). -- To view, visit https://gerrit.osmocom.org/11871 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd2431ad25d7fa182e52e2bd5231ceb04d427c34 Gerrit-Change-Number: 11871 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Sperling <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Thu, 22 Nov 2018 11:01:39 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
