Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11854 )
Change subject: fix use of partly initialized struct in tcp test ...................................................................... Patch Set 1: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/11854/1/test_apps/tcp.c File test_apps/tcp.c: https://gerrit.osmocom.org/#/c/11854/1/test_apps/tcp.c@72 PS1, Line 72: memset(&name, 0, sizeof(name)); (personally I like 'name = (struct sockaddr_in){};' -- whatever) -- To view, visit https://gerrit.osmocom.org/11854 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id6e488308a72be96cca6aa661f088d2c3c67a6a3 Gerrit-Change-Number: 11854 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Sperling <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Fri, 23 Nov 2018 15:38:39 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
