Vadim Yanitskiy has posted comments on this change. (
https://gerrit.osmocom.org/11914 )
Change subject: libmsc/gsm_04_11.c: don't pass msgb to gsm411_rx_rp_{ack|error}
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/11914/1/src/libmsc/gsm_04_11.c
File src/libmsc/gsm_04_11.c:
https://gerrit.osmocom.org/#/c/11914/1/src/libmsc/gsm_04_11.c@703
PS1, Line 703: static int gsm411_rx_rp_ack(struct gsm_trans *trans,
> so msg parma was not being used at all? strange compiler didn't warn/error
> about it.
Yeah, for some reason GCC doesn't even complain :/
--
To view, visit https://gerrit.osmocom.org/11914
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0eb5c7c485ab7d109966431bd875fa74e00936d7
Gerrit-Change-Number: 11914
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <[email protected]>
Gerrit-Reviewer: Vadim Yanitskiy <[email protected]>
Gerrit-Comment-Date: Sun, 25 Nov 2018 23:49:17 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
