Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11927 )
Change subject: ctrl: clarify use of id = 0 ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/11927/1/common/chapters/control_if.adoc File common/chapters/control_if.adoc: https://gerrit.osmocom.org/#/c/11927/1/common/chapters/control_if.adoc@58 PS1, Line 58: operation. Value `0` is not allowed unless it's a TRAP message. It will be echoed back in any Same here. Why do we send value 0 for trap? why not using incrementing number? -- To view, visit https://gerrit.osmocom.org/11927 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic00de5023e7a1ec6426a0178778d35b13c337271 Gerrit-Change-Number: 11927 Gerrit-PatchSet: 1 Gerrit-Owner: Max <[email protected]> Gerrit-CC: Jenkins Builder (1000002) Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Mon, 26 Nov 2018 09:59:29 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
