Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/11928 )
Change subject: ctrl: introduce constant for TRAP id
......................................................................
ctrl: introduce constant for TRAP id
Use it for TRAP message parsing and generation.
Change-Id: I0381eb60d10e7278b966464add79772a9f7c8118
---
M osmopy/osmo_ipa.py
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Pau Espin Pedrol: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/osmopy/osmo_ipa.py b/osmopy/osmo_ipa.py
index 246101d..41865c1 100755
--- a/osmopy/osmo_ipa.py
+++ b/osmopy/osmo_ipa.py
@@ -43,6 +43,7 @@
CTRL_REP = 'REPLY'
CTRL_ERR = 'ERR'
CTRL_TRAP = 'TRAP'
+ CTRL_TRAP_ID = 0
def _l(self, d, p):
"""
@@ -250,7 +251,7 @@
if s == self.CTRL_GET + '_' + self.CTRL_REP:
return i, v, None
(s, i, var, val) = data.split(' ', 3)
- if s == self.CTRL_TRAP and i != '0':
+ if s == self.CTRL_TRAP and int(i) != self.CTRL_TRAP_ID:
return i, None, None
return i, var, val
@@ -267,7 +268,7 @@
"""
Make TRAP message with given (vak, val) pair
"""
- return self.add_header("%s 0 %s %s" % (self.CTRL_TRAP, var, val))
+ return self.add_header("%s %d %s %s" % (self.CTRL_TRAP,
self.CTRL_TRAP_ID, var, val))
def cmd(self, var, val=None):
"""
--
To view, visit https://gerrit.osmocom.org/11928
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0381eb60d10e7278b966464add79772a9f7c8118
Gerrit-Change-Number: 11928
Gerrit-PatchSet: 2
Gerrit-Owner: Max <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <[email protected]>
Gerrit-Reviewer: Pau Espin Pedrol <[email protected]>
Gerrit-Reviewer: daniel <[email protected]>
