Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11936 )
Change subject: Move common Trap-related code into separate file ...................................................................... Patch Set 2: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/11936/2/scripts/ctrl2cgi.py File scripts/ctrl2cgi.py: https://gerrit.osmocom.org/#/c/11936/2/scripts/ctrl2cgi.py@32 PS2, Line 32: from trap_helper import Trap, reloader, debug_init Next time better break each of them into a separate patch please, otherwise there are too many changes. https://gerrit.osmocom.org/#/c/11936/2/scripts/trap_helper.py File scripts/trap_helper.py: https://gerrit.osmocom.org/#/c/11936/2/scripts/trap_helper.py@2 PS2, Line 2: from functools import partial Did you think about how is this file going to be installed? I bet it's not installed nor packaged in debian by default. Can you confirm? And if it's installed, is it installed in a correct place so that it can be imported by other python files? -- To view, visit https://gerrit.osmocom.org/11936 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7b59f2dbded9074d15f2d2f40bf5a92ed02601e2 Gerrit-Change-Number: 11936 Gerrit-PatchSet: 2 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: daniel <[email protected]> Gerrit-Comment-Date: Mon, 26 Nov 2018 16:54:58 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
