Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11943 )
Change subject: fix file descriptor leak in osysmon_file_read ...................................................................... Patch Set 1: Code-Review+2 (1 comment) OK to merge the first fix, but even nicer to fix the other one as well right away https://gerrit.osmocom.org/#/c/11943/1/osysmon_file.c File osysmon_file.c: https://gerrit.osmocom.org/#/c/11943/1/osysmon_file.c@96 PS1, Line 96: fclose(f); > Actually I think we can close it right after fgets() but before checking it's > result. […] I agree res = fgets(); fclose(f); if (res == NULL)... -- To view, visit https://gerrit.osmocom.org/11943 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie1b5734748438c6d785cd96dfa9af6303cd102da Gerrit-Change-Number: 11943 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Sperling <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-Comment-Date: Tue, 27 Nov 2018 11:18:29 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
