Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11949 )
Change subject: change scaling factor from .3 to .7 for lms sdr devices to improve the signal slope ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/11949/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/11949/1//COMMIT_MSG@7 PS1, Line 7: change scaling factor from .3 to .7 for lms sdr devices to improve the signal slope Prepend "lms:" for easy/quickly categorization of scope of the patch. Something like: lms: Change scaling factor from .3 to .7 to improve signal slope https://gerrit.osmocom.org/#/c/11949/1/Transceiver52M/device/lms/LMSDevice.h File Transceiver52M/device/lms/LMSDevice.h: https://gerrit.osmocom.org/#/c/11949/1/Transceiver52M/device/lms/LMSDevice.h@31 PS1, Line 31: // this was 0.3 before - values above 0.8 give more phase noise, values below 0.6 give too much amplitude resolution/noise to pass gmsk validation on a E4406 We usually use /* */ type comments. No need to specify it was 0.3 before, we have git log for that ;) Probably add word "experimentally found" or similar to understand it doesn't come from some spec sheets from producer. -- To view, visit https://gerrit.osmocom.org/11949 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d1ba5cbd4ba98f912eb2e3e9f5383b69b28ff5b Gerrit-Change-Number: 11949 Gerrit-PatchSet: 1 Gerrit-Owner: roh <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Tue, 27 Nov 2018 12:26:59 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
