Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11909 )
Change subject: osmo_ctrl.py: properly ignore out-of-order traps ...................................................................... Patch Set 4: Code-Review+1 (1 comment) (leaving +2 to pespin) https://gerrit.osmocom.org/#/c/11909/4/scripts/osmo_ctrl.py File scripts/osmo_ctrl.py: https://gerrit.osmocom.org/#/c/11909/4/scripts/osmo_ctrl.py@47 PS4, Line 47: if ret != None: (I'd even prefer 'if ret == None: continue' but nm) -- To view, visit https://gerrit.osmocom.org/11909 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia6de02c2f13a56f0381c97a9ab02c6c7a31cc32f Gerrit-Change-Number: 11909 Gerrit-PatchSet: 4 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: daniel <[email protected]> Gerrit-Comment-Date: Tue, 27 Nov 2018 22:33:39 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
