Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11955 )
Change subject: cosmetic: bsc: timeslot_fsm: Clean uneeded scope brackets ...................................................................... Patch Set 1: Code-Review+2 (1 comment) In my opinion, the scope nicely indicates that the struct is only used for signaling the other function, but we had this discussion before and I was overruled. https://gerrit.osmocom.org/#/c/11955/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/11955/1//COMMIT_MSG@7 PS1, Line 7: cosmetic: bsc: timeslot_fsm: Clean uneeded scope brackets and omit uneeded n? -- To view, visit https://gerrit.osmocom.org/11955 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5140f98e23b8c8d16ce0cca0be66297aaf0b5653 Gerrit-Change-Number: 11955 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Tue, 27 Nov 2018 22:37:53 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
