Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11953 )

Change subject: ctrl2cgi: fix deferred callbacks
......................................................................


Patch Set 2:

> (1 comment)
 >
 > Logging should be fixed in follow-up patches.

Fine, but I'd like to stop seeing code being moved somewhere and then moved 
back, stuff being removed and then added later, and so on. If you need to fix 
an issue there's no need to merge changes blindly, you can test it easily where 
the bug happens (it's python, just copy the file there one you have your 
changes).


--
To view, visit https://gerrit.osmocom.org/11953
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2c28dd7f79cbd28d475de93750703659ddd18f1
Gerrit-Change-Number: 11953
Gerrit-PatchSet: 2
Gerrit-Owner: Max <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <[email protected]>
Gerrit-Reviewer: Pau Espin Pedrol <[email protected]>
Gerrit-Reviewer: daniel <[email protected]>
Gerrit-Comment-Date: Wed, 28 Nov 2018 12:01:59 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No

Reply via email to