Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11985 )
Change subject: MSC_Tests.ttcn: introduce TC_lu_and_ss_session_timeout ...................................................................... Patch Set 3: Code-Review+2 (3 comments) https://gerrit.osmocom.org/#/c/11985/3/msc/MSC_Tests.ttcn File msc/MSC_Tests.ttcn: https://gerrit.osmocom.org/#/c/11985/3/msc/MSC_Tests.ttcn@2718 PS3, Line 2718: tid := 1, /* We just need a single transaction */ re comment: tid is an ID, not a count, right? https://gerrit.osmocom.org/#/c/11985/3/msc/MSC_Tests.ttcn@2742 PS3, Line 2742: cause := *, /* TODO: expect some specific value */ If a value shall be sent and you don't yet care which, then maybe '?' would be better. ('*' also matches if no cause is sent.) If there should be no cause because it was successful or something, instead use 'omit'. https://gerrit.osmocom.org/#/c/11985/3/msc/MSC_Tests.ttcn@2749 PS3, Line 2749: cause := ?); /* TODO: expect some specific value */ aha! :) -- To view, visit https://gerrit.osmocom.org/11985 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3e1791773d56617172ae27a46889a1ae4d400e2f Gerrit-Change-Number: 11985 Gerrit-PatchSet: 3 Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Comment-Date: Thu, 29 Nov 2018 14:19:42 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
