Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11942 )
Change subject: follow-up: logging tweak for Immediate Assignment ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/11942/1/src/osmo-bsc/lchan_fsm.c File src/osmo-bsc/lchan_fsm.c: https://gerrit.osmocom.org/#/c/11942/1/src/osmo-bsc/lchan_fsm.c@107 PS1, Line 107: * (Timeout?) was already logged elsewhere. Just tear down the lchan. */ > You talk about tearing down the lchan here, but I don't see any code doing > that? it's implicit after _lchan_on_activation_failure(). I mean, continue with the normal tear down stuff happening anyway, without sending some other message or logging. -- To view, visit https://gerrit.osmocom.org/11942 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I474cf1a58d1f00ec5b0ae52bd095a60aad763975 Gerrit-Change-Number: 11942 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Thu, 29 Nov 2018 19:43:44 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
