Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12016 )
Change subject: drop unused gsm_subscriber_connection->encr ...................................................................... Patch Set 4: Code-Review-1 according to 48.008 Ciphering Mode Complete, the BSC should send back the ciphering mode used (optional IE), and we do encode that IE in osmo-bsc. But osmo-msc doesn't decode that IE when receiving the Ciphering Mode Complete in msc_cipher_mode_compl(). So instead of dropping it, we should probably fix the IE parsing and populate the value. -- To view, visit https://gerrit.osmocom.org/12016 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice2c470c360612249f97301944c6fdf9443c7dce Gerrit-Change-Number: 12016 Gerrit-PatchSet: 4 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Fri, 30 Nov 2018 03:00:30 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes
