Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12045 )
Change subject: gerrit-verifications/master-builds: with_manuals ...................................................................... Patch Set 2: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/12045/2/jobs/master-builds.yml File jobs/master-builds.yml: https://gerrit.osmocom.org/#/c/12045/2/jobs/master-builds.yml@206 PS2, Line 206: cmd: GTP="$GTP" ./contrib/jenkins.sh --publish Shouldn't publish be called conditionally based on with_manuals? see GTP="$GTP" as example. Not sure how to apply it as a boolean to env var though, you may need to move them to strings. a2_name: MANUALS a2: !!python/tuple ["--enable-manuals", "--disable-manuals"] GTP="$GTP" MANUALS="$MANUALS" ./contrib/jenkins.sh --publish And then use $MANUALS inside jenkins.sh. -- To view, visit https://gerrit.osmocom.org/12045 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0643b17a6be6e86e281b50d78dd7a6858cf99ee Gerrit-Change-Number: 12045 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Fri, 30 Nov 2018 13:15:41 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
