Max has posted comments on this change. ( https://gerrit.osmocom.org/12020 )
Change subject: LCLS, TS 48.008: add GCR IE encoding/decoding ...................................................................... Patch Set 2: (1 comment) The rest should be addressed in next revision. https://gerrit.osmocom.org/#/c/12020/2/tests/gsm0808/gsm0808_test.c File tests/gsm0808/gsm0808_test.c: https://gerrit.osmocom.org/#/c/12020/2/tests/gsm0808/gsm0808_test.c@605 PS2, Line 605: printf("parsing failed: %s [%s]\n", strerror(-rc), msgb_hexdump(msg)); > Exit or at last return in all failed cases. Same comment as in one of the previous commits - why? -- To view, visit https://gerrit.osmocom.org/12020 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82ce0207dc8de50689a8806c6471ad7fbae6219d Gerrit-Change-Number: 12020 Gerrit-PatchSet: 2 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Fri, 30 Nov 2018 14:59:20 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
