Vadim Yanitskiy has submitted this change and it was merged. (
https://gerrit.osmocom.org/11990 )
Change subject: library/GSUP_Types.ttcn: fix IE order in PROC_SS_ERROR templates
......................................................................
library/GSUP_Types.ttcn: fix IE order in PROC_SS_ERROR templates
In general, the order of IEs in a GSUP message doesn't matter.
Despite libosmocore's GSUP API encodes IEs in a fixed order,
it is capable to decode them in any arbitary order.
Meanwhile, in the current TTCN-3 definitions (i.e. templates)
the order makes a difference, because the 'GSUP_IEs' type is
a record, that according to the TTCN-3 documentation represents
an *ordered* sequence of elements.
Let's reorder the IEs of both t{r|s}_GSUP_PROC_SS_ERR templates
in a way that is used by the libosmocore's GSUP encoder.
This correction doesn't affect successful test case executions,
because we don't test possible problematic situations yet. But
if something went wrong on the HLR side (i.e. SUT), the matching
statements wouldn't match the PROC_SS_ERR message correctly
and continue to wait until the guard timer is expired.
Change-Id: I5eb2314f6a9ab0e9fc5e836390414cec6e1a12db
---
M library/GSUP_Types.ttcn
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Harald Welte: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/library/GSUP_Types.ttcn b/library/GSUP_Types.ttcn
index cadc6d8..6329ebd 100644
--- a/library/GSUP_Types.ttcn
+++ b/library/GSUP_Types.ttcn
@@ -698,9 +698,9 @@
OSMO_GSUP_MSGT_PROC_SS_ERROR,
{
valueof(ts_GSUP_IE_IMSI(imsi)),
+ valueof(ts_GSUP_IE_Cause(cause)),
valueof(ts_GSUP_IE_SessionId(sid)),
- valueof(ts_GSUP_IE_SessionState(state)),
- valueof(ts_GSUP_IE_Cause(cause))
+ valueof(ts_GSUP_IE_SessionState(state))
}
);
template GSUP_PDU tr_GSUP_PROC_SS_ERR(
@@ -712,9 +712,9 @@
OSMO_GSUP_MSGT_PROC_SS_ERROR,
{
tr_GSUP_IE_IMSI(imsi),
+ tr_GSUP_IE_Cause(cause),
tr_GSUP_IE_SessionId(sid),
- tr_GSUP_IE_SessionState(state),
- tr_GSUP_IE_Cause(cause)
+ tr_GSUP_IE_SessionState(state)
}
);
--
To view, visit https://gerrit.osmocom.org/11990
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5eb2314f6a9ab0e9fc5e836390414cec6e1a12db
Gerrit-Change-Number: 11990
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Vadim Yanitskiy <[email protected]>
