Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12051 )
Change subject: UHDDevice.cpp uhd_device::open() uhd::usrp::multi_usrp::make() added actual exception from uhd::key_error to extend debugging ...................................................................... Patch Set 1: Code-Review-1 (2 comments) Please, re-submit the patch (remember to keep the same Change-Id!) with the changes requested applied so we can merge it. Thanks for contributing! https://gerrit.osmocom.org/#/c/12051/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/12051/1//COMMIT_MSG@7 PS1, Line 7: UHDDevice.cpp uhd_device::open() uhd::usrp::multi_usrp::make() added actual exception from uhd::key_error to extend debugging First line of commit is way to long. What about: UHDDevice: log exception information on device open failure https://gerrit.osmocom.org/#/c/12051/1/Transceiver52M/device/uhd/UHDDevice.cpp File Transceiver52M/device/uhd/UHDDevice.cpp: https://gerrit.osmocom.org/#/c/12051/1/Transceiver52M/device/uhd/UHDDevice.cpp@640 PS1, Line 640: LOGC(DDEV, ALERT) << "UHD make execption output:\n" << e.what(); typo: exception -- To view, visit https://gerrit.osmocom.org/12051 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic33f4068d40cac3221960634185b697e10288dd1 Gerrit-Change-Number: 12051 Gerrit-PatchSet: 1 Gerrit-Owner: d0gtail <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Fri, 30 Nov 2018 22:03:46 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
