d0gtail has posted comments on this change. ( https://gerrit.osmocom.org/12052 )
Change subject: UHDDevice: log exception information on device open failure ...................................................................... Patch Set 2: (1 comment) > Patch Set 2: > > (1 comment) https://gerrit.osmocom.org/#/c/12052/2/Transceiver52M/device/uhd/UHDDevice.cpp File Transceiver52M/device/uhd/UHDDevice.cpp: https://gerrit.osmocom.org/#/c/12052/2/Transceiver52M/device/uhd/UHDDevice.cpp@639 PS2, Line 639: "\nUHD make execption output:\n" > Sorry, but I actually meant *logging line*, not a code line: […] Ah ok I see what you mean. Of course we can go that route. But can we seperate the exception into a new line because it's most of the time a multiline output and looks weired if not seperatet imho: LOGC(DDEV, ALERT) << "UHD make failed, device " << args << ", exception:\n" << e.what(); -- To view, visit https://gerrit.osmocom.org/12052 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia84ddcf50cc83f9326b22bfdfb4f259b4e0bc5f1 Gerrit-Change-Number: 12052 Gerrit-PatchSet: 2 Gerrit-Owner: d0gtail <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: d0gtail <[email protected]> Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-CC: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Sat, 01 Dec 2018 14:05:40 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
