Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12048 )
Change subject: SS/USSD: make NCSS session timeout configurable ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/12048/2/src/hlr_vty.c File src/hlr_vty.c: https://gerrit.osmocom.org/#/c/12048/2/src/hlr_vty.c@291 PS2, Line 291: if (g_hlr->ncss_guard_timeout > 0) > I think this should check for != DEFAULT and only save a non-default value. Sure, thanks! Copy-pasted :/ -- To view, visit https://gerrit.osmocom.org/12048 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I971fc2cee6fd46d4d5d6dac6c634e0b22fff183d Gerrit-Change-Number: 12048 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Mon, 03 Dec 2018 13:23:09 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
