Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/11926 )
Change subject: ctrl: use #define for TRAP id
......................................................................
ctrl: use #define for TRAP id
We always use id = 0 when sending TRAP messages. Let's make this more
obvious by introducing appropriate define.
Change-Id: I33d7d4c6a1885a75a85d6f2f017430e0860b4126
---
M include/osmocom/ctrl/control_cmd.h
M src/ctrl/control_if.c
2 files changed, 2 insertions(+), 1 deletion(-)
Approvals:
Neels Hofmeyr: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/include/osmocom/ctrl/control_cmd.h
b/include/osmocom/ctrl/control_cmd.h
index 93055c7..276a7de 100644
--- a/include/osmocom/ctrl/control_cmd.h
+++ b/include/osmocom/ctrl/control_cmd.h
@@ -12,6 +12,7 @@
#define CTRL_CMD_ERROR -1
#define CTRL_CMD_HANDLED 0
#define CTRL_CMD_REPLY 1
+#define CTRL_CMD_TRAP_ID "0"
struct ctrl_handle;
diff --git a/src/ctrl/control_if.c b/src/ctrl/control_if.c
index 1121d07..0209f3b 100644
--- a/src/ctrl/control_if.c
+++ b/src/ctrl/control_if.c
@@ -156,7 +156,7 @@
if (!cmd)
return -ENOMEM;
- cmd->id = "0"; /* It's a TRAP! */
+ cmd->id = CTRL_CMD_TRAP_ID; /* It's a TRAP! */
cmd->variable = (char *) name;
cmd->reply = value;
r = ctrl_cmd_send_to_all(ctrl, cmd);
--
To view, visit https://gerrit.osmocom.org/11926
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I33d7d4c6a1885a75a85d6f2f017430e0860b4126
Gerrit-Change-Number: 11926
Gerrit-PatchSet: 2
Gerrit-Owner: Max <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <[email protected]>
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: daniel <[email protected]>
Gerrit-CC: Pau Espin Pedrol <[email protected]>
