Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11976 )
Change subject: contrib/jenkins.sh: build and publish manuals ...................................................................... Patch Set 6: (1 comment) https://gerrit.osmocom.org/#/c/11976/6/contrib/jenkins.sh File contrib/jenkins.sh: https://gerrit.osmocom.org/#/c/11976/6/contrib/jenkins.sh@33 PS6, Line 33: osmo-build-dep.sh osmo-gsm-manuals For projectes where we don't have a build matrix (so we always build manuals), I think it would make more sense to still have the WITH_MANUALS check here, and pass the env var in all cases. -- To view, visit https://gerrit.osmocom.org/11976 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1a6ab64c7912f30a693ca4f5f474f22d72b8873 Gerrit-Change-Number: 11976 Gerrit-PatchSet: 6 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Comment-Date: Tue, 04 Dec 2018 11:18:28 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
