Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12092 )
Change subject: Allow log_init() with NULL log_info ...................................................................... Patch Set 1: (3 comments) https://gerrit.osmocom.org/#/c/12092/1/src/logging.c File src/logging.c: https://gerrit.osmocom.org/#/c/12092/1/src/logging.c@951 PS1, Line 951: * \param[in] inf Information regarding logging categories Document new behavior. https://gerrit.osmocom.org/#/c/12092/1/src/logging.c@972 PS1, Line 972: /* total number = number of user cat + library cat */ Commment IMHO not needed. https://gerrit.osmocom.org/#/c/12092/1/src/logging.c@985 PS1, Line 985: if (inf) /* copy over the user part */ multiline condition, please better add {} -- To view, visit https://gerrit.osmocom.org/12092 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42159780b57684bff225789f036f28a4b25fc7b8 Gerrit-Change-Number: 12092 Gerrit-PatchSet: 1 Gerrit-Owner: Max <[email protected]> Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Tue, 04 Dec 2018 11:50:19 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
